refactor: ESM and TypeScript-as-JavaScript#18
Open
brettz9 wants to merge 1 commit intoAWinterman:masterfrom
Open
refactor: ESM and TypeScript-as-JavaScript#18brettz9 wants to merge 1 commit intoAWinterman:masterfrom
brettz9 wants to merge 1 commit intoAWinterman:masterfrom
Conversation
BREAKING CHANGE: Adds `exports`. Also: - chore: update eslint
Collaborator
Author
|
@AWinterman ... Hi Andrew... Not sure if you wanted to review first before making a release... This adds TypeScript as well as modernizes to use ES modules. It's technically a breaking change as it adds an |
Collaborator
Author
|
Do you think you'll have time to review? Otherwise, I can make a fork... Wanted to also add a sync version. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: ESM and TypeScript-as-JavaScript
BREAKING CHANGE:
Adds
exports.Also: